Omega359 commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797270367
##########
datafusion/functions/src/datetime/to_date.rs:
##########
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
ColumnarValue, Documentation, ScalarUDFImpl, Signature, Volatility,
};
+use datafusion_macros::udf_doc;
use std::any::Any;
use std::sync::OnceLock;
+#[udf_doc(
Review Comment:
I dumped the example #[udf_doc ...] into my editor to do a direct comparison
to the existing solution and to be honest it definitely is nicer to visually
parse.
There are situations currently where this approach will not work, at least
as it currently seems to be implemented. For example:
[bit_and_or_xor](https://github.com/apache/datafusion/blob/main/datafusion/functions-aggregate/src/bit_and_or_xor.rs),
some of the regex udfs, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
