comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797461538
##########
datafusion/functions/src/datetime/to_date.rs:
##########
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
ColumnarValue, Documentation, ScalarUDFImpl, Signature, Volatility,
};
+use datafusion_macros::udf_doc;
use std::any::Any;
use std::sync::OnceLock;
+#[udf_doc(
+ doc_section(include = "true", label = "Time and Date Functions"),
Review Comment:
I'm not sure if enum/constant can be used directly within the attribute,
however there is a possibility to check the value in macro. So if the value is
not satisfied to existing enum variants the macro can throw an exception with
explaining what section names are supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
