alamb commented on PR #12816: URL: https://github.com/apache/datafusion/pull/12816#issuecomment-2408940698
Here is the performance of this PR. Some queries are slower, some are faster. I believe once we turn on string view everything will be faster. ``` -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ feature_12788-binary-as-string-… ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2.26ms │ 2.22ms │ no change │ │ QQuery 1 │ 38.78ms │ 38.16ms │ no change │ │ QQuery 2 │ 92.96ms │ 94.66ms │ no change │ │ QQuery 3 │ 98.39ms │ 100.72ms │ no change │ │ QQuery 4 │ 928.83ms │ 929.22ms │ no change │ │ QQuery 5 │ 973.20ms │ 988.39ms │ no change │ │ QQuery 6 │ 33.75ms │ 36.60ms │ 1.08x slower │ │ QQuery 7 │ 42.31ms │ 42.33ms │ no change │ │ QQuery 8 │ 1383.69ms │ 1364.35ms │ no change │ │ QQuery 9 │ 1323.14ms │ 1361.55ms │ no change │ │ QQuery 10 │ 351.92ms │ 413.62ms │ 1.18x slower │ │ QQuery 11 │ 400.63ms │ 462.88ms │ 1.16x slower │ │ QQuery 12 │ 1095.05ms │ 1101.34ms │ no change │ │ QQuery 13 │ 1753.33ms │ 1676.37ms │ no change │ │ QQuery 14 │ 1220.66ms │ 1253.31ms │ no change │ │ QQuery 15 │ 1099.67ms │ 1091.86ms │ no change │ │ QQuery 16 │ 2530.60ms │ 2536.06ms │ no change │ │ QQuery 17 │ 2299.37ms │ 2317.53ms │ no change │ │ QQuery 18 │ 5042.06ms │ 4983.43ms │ no change │ │ QQuery 19 │ 94.19ms │ 95.74ms │ no change │ │ QQuery 20 │ 1720.68ms │ 1493.36ms │ +1.15x faster │ │ QQuery 21 │ 2074.60ms │ 1824.64ms │ +1.14x faster │ │ QQuery 22 │ 5257.20ms │ 3143.86ms │ +1.67x faster │ │ QQuery 23 │ 10530.69ms │ 10229.16ms │ no change │ │ QQuery 24 │ 590.29ms │ 654.78ms │ 1.11x slower │ │ QQuery 25 │ 489.54ms │ 523.81ms │ 1.07x slower │ │ QQuery 26 │ 653.48ms │ 714.03ms │ 1.09x slower │ │ QQuery 27 │ 2585.81ms │ 2285.59ms │ +1.13x faster │ │ QQuery 28 │ 15372.17ms │ 15562.00ms │ no change │ │ QQuery 29 │ 530.70ms │ 529.82ms │ no change │ │ QQuery 30 │ 1031.82ms │ 1094.30ms │ 1.06x slower │ │ QQuery 31 │ 1121.86ms │ 1139.77ms │ no change │ │ QQuery 32 │ 4358.25ms │ 4290.06ms │ no change │ │ QQuery 33 │ 5154.15ms │ 5209.55ms │ no change │ │ QQuery 34 │ 5133.94ms │ 5172.32ms │ no change │ │ QQuery 35 │ 1947.97ms │ 1895.07ms │ no change │ │ QQuery 36 │ 270.40ms │ 262.39ms │ no change │ │ QQuery 37 │ 121.52ms │ 126.73ms │ no change │ │ QQuery 38 │ 143.79ms │ 141.60ms │ no change │ │ QQuery 39 │ 758.06ms │ 767.78ms │ no change │ │ QQuery 40 │ 52.74ms │ 56.09ms │ 1.06x slower │ │ QQuery 41 │ 48.60ms │ 50.59ms │ no change │ │ QQuery 42 │ 64.42ms │ 63.09ms │ no change │ └──────────────┴────────────┴──────────────────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
