jcsherin commented on code in PR #12811:
URL: https://github.com/apache/datafusion/pull/12811#discussion_r1802500550
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -252,31 +287,35 @@ fn create_built_in_window_expr(
}
}
BuiltInWindowFunction::Lag => {
- let arg = Arc::clone(&args[0]);
+ // rewrite NULL expression and the return datatype
+ let (arg, out_data_type) =
+ rewrite_null_expr_and_data_type(args, out_data_type)?;
let shift_offset = get_scalar_value_from_args(args, 1)?
.map(get_signed_integer)
.map_or(Ok(None), |v| v.map(Some))?;
let default_value =
- get_casted_value(get_scalar_value_from_args(args, 2)?,
out_data_type)?;
+ get_casted_value(get_scalar_value_from_args(args, 2)?,
&out_data_type)?;
Arc::new(lag(
name,
- out_data_type.clone(),
+ default_value.data_type().clone(),
Review Comment:
Note: This works because 1st and 3rd arguments ends up having the same
datatype after parsing the arguments above (for all cases). So passing
`out_data_type.clone()` (per diff) as an argument here is also correct.
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
