jcsherin commented on code in PR #12811:
URL: https://github.com/apache/datafusion/pull/12811#discussion_r1802501953
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -217,6 +217,41 @@ fn get_casted_value(
}
}
+/// Rewrites the NULL expression (1st argument) with an expression
+/// which is the same data type as the default value (3rd argument).
+/// Also rewrites the return type with the same data type as the
+/// default value.
+///
+/// If a default value is not provided, or it is NULL the original
+/// expression (1st argument) and return type is returned without
+/// any modifications.
+fn rewrite_null_expr_and_data_type(
+ args: &[Arc<dyn PhysicalExpr>],
+ expr_type: &DataType,
+) -> Result<(Arc<dyn PhysicalExpr>, DataType)> {
+ assert!(!args.is_empty());
+ let expr = Arc::clone(&args[0]);
+
+ // The input expression and the return is type is unchanged
+ // when the input expression is not NULL.
+ if !expr_type.is_null() {
+ return Ok((expr, expr_type.clone()));
+ }
+
+ get_scalar_value_from_args(args, 2)?
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
