andygrove commented on code in PR #1022:
URL: https://github.com/apache/datafusion-comet/pull/1022#discussion_r1806770379
##########
native/core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -55,17 +55,25 @@ use datafusion::{
},
};
use datafusion_physical_expr::EquivalenceProperties;
+use futures::executor::block_on;
use futures::{lock::Mutex, Stream, StreamExt, TryFutureExt, TryStreamExt};
use itertools::Itertools;
use simd_adler32::Adler32;
-use tokio::task;
use crate::{
common::bit::ceil,
errors::{CometError, CometResult},
};
use datafusion_comet_spark_expr::spark_hash::create_murmur3_hashes;
+/// The status of appending rows to a partition buffer.
+enum AppendRowStatus {
+ /// The difference in memory usage after appending rows
+ MemDiff(Result<isize>),
Review Comment:
Will this always be an increase in memory? Should this use `usize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
