andygrove commented on code in PR #988:
URL: https://github.com/apache/datafusion-comet/pull/988#discussion_r1797486156
##########
native/core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -1504,25 +1586,65 @@ mod test {
#[test]
#[cfg_attr(miri, ignore)] // miri can't call foreign function
`ZSTD_createCCtx`
fn test_insert_larger_batch() {
+ shuffle_write_test(10000, 1, 16, None);
+ }
+
+ #[test]
+ #[cfg_attr(miri, ignore)] // miri can't call foreign function
`ZSTD_createCCtx`
+ fn test_insert_smaller_batch() {
+ shuffle_write_test(1000, 1, 16, None);
+ shuffle_write_test(1000, 10, 16, None);
+ }
+
+ #[test]
+ #[cfg_attr(miri, ignore)] // miri can't call foreign function
`ZSTD_createCCtx`
+ #[cfg(not(target_os = "macos"))] // Github MacOS runner fails with "Too
many open files".
Review Comment:
This PR seems like an important improvement because it now uses the memory
pool features. Perhaps we can follow up with optimizations to reduce spilling.
wdyt @Kontinuation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
