Dandandan commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1807857538
##########
datafusion/physical-plan/src/aggregates/group_values/column.rs:
##########
@@ -160,11 +162,112 @@ macro_rules! instantiate_primitive {
};
}
-fn append_col_value<C>(mut core: C, array: &ArrayRef, row: usize)
-where
- C: FnMut(&ArrayRef, usize),
-{
- core(array, row);
+struct AggregationHashTable<T: AggregationHashTableEntry> {
+ /// Raw table storing values in a `Vec`
+ raw_table: Vec<T>,
Review Comment:
The reason I think is that the lookup is incredibly well optimized using the
swiss table design and you get fewer 'false" candidates to check for, while we
can still use the vectorized/type specialized equality check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
