Dandandan commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1807856591
##########
datafusion/physical-plan/src/aggregates/group_values/column.rs:
##########
@@ -160,11 +162,112 @@ macro_rules! instantiate_primitive {
};
}
-fn append_col_value<C>(mut core: C, array: &ArrayRef, row: usize)
-where
- C: FnMut(&ArrayRef, usize),
-{
- core(array, row);
+struct AggregationHashTable<T: AggregationHashTableEntry> {
+ /// Raw table storing values in a `Vec`
+ raw_table: Vec<T>,
Review Comment:
We can still do "vectorized compare" by doing the lookup in the hashtable
(based on hash value only) and the vectorized equality check separately. That
way you still can use the fast hashtable, but move the equality check to a
separate/vectorized step.
That's at least what is done in the vectorized hash join implementation :).
I changed it before to use a `Vec`-based index like you did here, but that
performed significantly worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
