findepi commented on code in PR #13029:
URL: https://github.com/apache/datafusion/pull/13029#discussion_r1808507867
##########
datafusion/physical-plan/src/common.rs:
##########
@@ -156,7 +156,11 @@ pub fn compute_record_batch_statistics(
for partition in batches.iter() {
for batch in partition {
for (stat_index, col_index) in projection.iter().enumerate() {
- null_counts[stat_index] +=
batch.column(*col_index).null_count();
Review Comment:
The meaning of this line was apparently changed in
https://github.com/apache/arrow-rs/pull/4691
At least it seems so from this diff line
https://github.com/apache/arrow-rs/commit/979a070dc82eeb26b38a8651cac879b2c276c0ed#diff-0cfddb6ef017ce20c5e7f528095956b2433cf2ea2d17e28ba4b515b7c1bd2e57L179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
