findepi commented on code in PR #13029:
URL: https://github.com/apache/datafusion/pull/13029#discussion_r1808569887
##########
datafusion/physical-plan/src/common.rs:
##########
@@ -156,7 +156,11 @@ pub fn compute_record_batch_statistics(
for partition in batches.iter() {
for batch in partition {
for (stat_index, col_index) in projection.iter().enumerate() {
- null_counts[stat_index] +=
batch.column(*col_index).null_count();
+ null_counts[stat_index] += batch
+ .column(*col_index)
+ .logical_nulls()
+ .map(|nulls| nulls.null_count())
Review Comment:
This could be simplified back if we had something like
https://github.com/apache/arrow-rs/pull/6608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
