comphead commented on code in PR #13025:
URL: https://github.com/apache/datafusion/pull/13025#discussion_r1809084468
##########
datafusion/optimizer/src/eliminate_cross_join.rs:
##########
@@ -253,13 +269,7 @@ fn flatten_join_inputs(
fn can_flatten_join_inputs(plan: &LogicalPlan) -> bool {
// can only flatten inner / cross joins
Review Comment:
perhaps we can add the reason why only inner/cross joins can be flattened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
