Dandandan commented on code in PR #13025: URL: https://github.com/apache/datafusion/pull/13025#discussion_r1809656972
########## datafusion/sqllogictest/test_files/join.slt: ########## @@ -1152,7 +1152,7 @@ logical_plan 01)Projection: t1.v0, t1.v1, t5.v2, t5.v3, t5.v4, t0.v0, t0.v1 02)--Inner Join: CAST(t1.v0 AS Float64) = t0.v1 Filter: t0.v1 + CAST(t5.v0 AS Float64) > Float64(0) 03)----Projection: t1.v0, t1.v1, t5.v0, t5.v2, t5.v3, t5.v4 -04)------Inner Join: Using t1.v0 = t5.v0, t1.v1 = t5.v1 +04)------Inner Join: t1.v0 = t5.v0, t1.v1 = t5.v1 Review Comment: Yeah it's just the rule now "rewrites" it, before it didn't because of the filter in the join above it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
