dhegberg opened a new pull request, #13079:
URL: https://github.com/apache/datafusion/pull/13079
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #9684.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Dataframe's `write_parquet()` was identified as incorrectly identifying
paths without an extension as a single file output.
This change updates `start_demuxer_task` to respect the suggested behaviour:
```
tmp/dataset/ -> is a folder since it ends in /
tmp/dataset -> is still a folder since it does not end in / but has no
valid file extension
tmp/file.parquet -> is a file since it does not end in / and has a valid
file extension .parquet
tmp/file.parquet/ -> is a folder since it ends in /
```
## What changes are included in this PR?
* Add `file_extension()` to `ListingTableUrl` to return an Optional extension
* Update `start_demuxer_task()` to require the presence of an extension from
the `ListingTableUrl` to set `single_file_output` to true
* Rename `file_extension` to `default_extension` to indicate usage will be
ignored if `single_file_output` is triggered.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
* Unit tests added for `file_extension()`
* Unit tests added for `Dataframe.write_parquet()` for paths with and
without extensions.
* No direct testing for `start_demuxer_task` since there was no direct
testing originally. I can revise and test this directly if preferred.
Testing via `cargo test -- --test-threads=1`
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
* Yes, the file output write behaviour is changing.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
