berkaysynnada commented on PR #13054:
URL: https://github.com/apache/datafusion/pull/13054#issuecomment-2434890005

   > How would you display them in sources? The dynamic filter will only be 
added during execution, so it will only be available through e.g. ParquetExec 
after loading the build side.
   
   Doesn’t `JoinFilterPushdown: PhysicalOptimizerRule` modify the 
`dynamic_filters` in `ParquetExec` during optimizations? My intention was to 
ensure the rule is functioning correctly and to prevent this feature from being 
silently broken in the future. Perhaps we could add some unit tests to verify 
this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to