Dandandan commented on PR #13101: URL: https://github.com/apache/datafusion/pull/13101#issuecomment-2437865910
I think it's interesting to run some more Parquet benchmarks as well to detect any regression. It looks like query 18 of TPC-H is still a tiny bit slower maybe (ran it a few times in a row). The rest is as fast or faster: ```-------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ enable_string_view_by_default2 ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 119.79ms │ 124.32ms │ no change │ │ QQuery 2 │ 60.37ms │ 57.00ms │ +1.06x faster │ │ QQuery 3 │ 59.15ms │ 57.28ms │ no change │ │ QQuery 4 │ 48.39ms │ 42.35ms │ +1.14x faster │ │ QQuery 5 │ 81.52ms │ 83.75ms │ no change │ │ QQuery 6 │ 22.36ms │ 22.13ms │ no change │ │ QQuery 7 │ 98.51ms │ 95.09ms │ no change │ │ QQuery 8 │ 81.93ms │ 79.63ms │ no change │ │ QQuery 9 │ 119.90ms │ 118.43ms │ no change │ │ QQuery 10 │ 117.68ms │ 108.71ms │ +1.08x faster │ │ QQuery 11 │ 41.15ms │ 40.82ms │ no change │ │ QQuery 12 │ 82.15ms │ 55.54ms │ +1.48x faster │ │ QQuery 13 │ 137.08ms │ 121.33ms │ +1.13x faster │ │ QQuery 14 │ 41.28ms │ 38.38ms │ +1.08x faster │ │ QQuery 15 │ 48.88ms │ 47.84ms │ no change │ │ QQuery 16 │ 42.21ms │ 38.53ms │ +1.10x faster │ │ QQuery 17 │ 107.27ms │ 108.30ms │ no change │ │ QQuery 18 │ 156.68ms │ 170.70ms │ 1.09x slower │ │ QQuery 19 │ 80.49ms │ 67.76ms │ +1.19x faster │ │ QQuery 20 │ 68.77ms │ 66.18ms │ no change │ │ QQuery 21 │ 125.50ms │ 128.51ms │ no change │ │ QQuery 22 │ 34.73ms │ 35.04ms │ no change │ └──────────────┴──────────┴────────────────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
