alamb commented on code in PR #13101:
URL: https://github.com/apache/datafusion/pull/13101#discussion_r1817012084
##########
benchmarks/src/util/options.rs:
##########
@@ -37,11 +37,6 @@ pub struct CommonOpt {
/// Activate debug mode to see more details
#[structopt(short, long)]
pub debug: bool,
-
- /// If true, will use StringView/BinaryViewArray instead of
String/BinaryArray
- /// when reading ParquetFiles
- #[structopt(long)]
- pub force_view_types: bool,
Review Comment:
👍 There is a kill switch (in the description of this PR)
> > set datafusion.execution.parquet.schema_force_view_types = false;
> 0 row(s) fetched.
> Elapsed 0.000 seconds.
This particular code is for the benchmark drivers and I don't think it is
super valuable to retain the benchmark in both configurations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
