alamb commented on code in PR #13090:
URL: https://github.com/apache/datafusion/pull/13090#discussion_r1817771852
##########
benchmarks/bench.sh:
##########
@@ -537,10 +541,12 @@ run_external_aggr() {
echo "RESULTS_FILE: ${RESULTS_FILE}"
echo "Running external aggregation benchmark..."
- # Only parquet is supported
- # External aggregation is not stable yet, set partitions to 4 to make sure
- # this benchmark can always run.
- $CARGO_COMMAND --bin external_aggr -- benchmark -n 4 --iterations 5 --path
"${TPCH_DIR}" -o "${RESULTS_FILE}"
+ # Only parquet is supported.
+ # Since per-operator memory limit is calculated as (total-memory-limit /
+ # number-of-partitions), and by default `--partitions` is set to number of
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
