vbarua commented on code in PR #13127:
URL: https://github.com/apache/datafusion/pull/13127#discussion_r1817926340
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -934,14 +963,15 @@ pub async fn from_substrait_rel(
_ => {
not_impl_err!("Unsupported ReadType: {:?}",
&read.as_ref().read_type)
}
- }
+ }?;
+ apply_emit_kind(read.common.as_ref(), plan)
Review Comment:
At this time, I've chosen to handle emits on ReadRels as DataFusion
Projections.
Future work can be done to optimize this and push the output mappings
further down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
