tokoko commented on code in PR #13127:
URL: https://github.com/apache/datafusion/pull/13127#discussion_r1817962436
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -934,14 +963,15 @@ pub async fn from_substrait_rel(
_ => {
not_impl_err!("Unsupported ReadType: {:?}",
&read.as_ref().read_type)
}
- }
+ }?;
+ apply_emit_kind(read.common.as_ref(), plan)
Review Comment:
same here. I'd leave it as is. pushdown is better done by some sort of
substrait optimizer beforehand or by DF optimizer afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
