berkaysynnada commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1818027754
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -127,12 +148,18 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
metrics,
aborted: false,
cursors: (0..stream_count).map(|_| None).collect(),
+ prev_cursors: (0..stream_count).map(|_| None).collect(),
+ round_robin_tie_breaker_mode: false,
+ num_of_polled_with_same_value: vec![0; stream_count],
Review Comment:
I agree that. It would not be trivial for more than 2 partitions, and I
think it would not bring a significant improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
