jayzhan211 commented on code in PR #13133:
URL: https://github.com/apache/datafusion/pull/13133#discussion_r1818076266
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -127,12 +148,18 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
metrics,
aborted: false,
cursors: (0..stream_count).map(|_| None).collect(),
+ prev_cursors: (0..stream_count).map(|_| None).collect(),
+ round_robin_tie_breaker_mode: false,
+ num_of_polled_with_same_value: vec![0; stream_count],
Review Comment:
A challenge here is the assumption that the next index is p+1, whereas it
could actually be p+r (any number).
For example, with 4 partitions and values 100, 100, 120, 100, if we choose
indices 0 and 1, the next one should be 3. However, with your approach, finding
the next index with the same value isn’t straightforward—it’s 1+2 in this case,
but it could also be 1+ any other number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
