findepi commented on PR #12978:
URL: https://github.com/apache/datafusion/pull/12978#issuecomment-2441489968
> Some sqllogictests failed and this is expected. @adriangb can you please
update them with
>
> ```
> cargo test --test sqllogictests -- --complete
> ```
>
You will need to merge with `main` to reproduce the failures (the failing
tests are new).
When you do so, you should get a diff like this
```diff
@@ -510,7 +510,7 @@ physical_plan
01)CoalesceBatchesExec: target_batch_size=8192
02)--FilterExec: binary_col@0 LIKE %a% AND largebinary_col@1 LIKE %a% AND
binaryview_col@2 LIKE %a%
03)----RepartitionExec: partitioning=RoundRobinBatch(2), input_partitions=1
-04)------ParquetExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet/binary_as_string.parquet]]},
projection=[binary_col, largebinary_col, binaryview_col],
predicate=binary_col@0 LIKE %a% AND largebinary_col@1 LIKE %a% AND
binaryview_col@2 LIKE %a%
+04)------ParquetExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/parquet/binary_as_string.parquet]]},
projection=[binary_col, largebinary_col, binaryview_col],
predicate=binary_col@0 LIKE %a% AND largebinary_col@1 LIKE %a% AND
binaryview_col@2 LIKE %a%, pruning_predicate=CASE WHEN binary_col_null_count@2
= binary_col_row_count@3 THEN false ELSE binary_col_min@0 <= � AND <=
binary_col_max@1 END AND CASE WHEN largebinary_col_null_count@6 =
largebinary_col_row_count@7 THEN false ELSE largebinary_col_min@4 <= � AND <=
largebinary_col_max@5 END AND CASE WHEN binaryview_col_null_count@10 =
binaryview_col_row_count@11 THEN false ELSE binaryview_col_min@8 <= � AND <=
binaryview_col_max@9 END, required_guarantees=[]
```
thoughts
- for a predicate `LIKE %a%` we should not generate additional conditions at
all. There is no min,max predicate we can practically derive from `LIKE %a%`
expression.
- `�` character is problematic to read and to work with. Some tools don't
handle it properly. For example when pasting into iterm with python3 running
for inspection, it got displaed as `\U+0FFFF` even though this is code
point`x10FFFF`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
