alamb commented on code in PR #13086:
URL: https://github.com/apache/datafusion/pull/13086#discussion_r1820616189
##########
Cargo.toml:
##########
@@ -169,3 +169,4 @@ large_futures = "warn"
[workspace.lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ["cfg(tarpaulin)"] }
+unused_qualifications = "deny"
Review Comment:
❤️
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -102,6 +103,7 @@ async fn test_inner_join_1k_filtered() {
}
#[tokio::test]
+#[allow(unused_qualifications)]
Review Comment:
is this something you can file ? I suspect it will be a good first issue
for someone
##########
datafusion/physical-plan/src/aggregates/order/partial.rs:
##########
@@ -22,6 +22,7 @@ use datafusion_common::Result;
use datafusion_execution::memory_pool::proxy::VecAllocExt;
use datafusion_expr::EmitTo;
use datafusion_physical_expr::PhysicalSortExpr;
+use std::mem::size_of;
Review Comment:
Not sure what you mean here
I think newer versions of rust automatically import `size_of` but whatever
Rust version we have defined as the minimum supported version still requires an
explicit import here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
