dhegberg commented on PR #13086: URL: https://github.com/apache/datafusion/pull/13086#issuecomment-2440188367
@findepi I've added the new linter check. One thing I struggled with was the generated code in `datafusion/proto`, I ended up removing the workspace lint setting from that Cargo.toml. I looked at: * Modifying the code generation to include `#[allow()]` statements, but that only seemed possible in `prost_build` but not `pbjson`. It also made the resulting code very noisy with overrides. * Adding a step to `./datafusion/proto/regen.sh` that ran `cargo fix` but the workspace linters don't seem to trigger when the manifest is run directly. I'm not sure if there something else that needs to be modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
