peter-toth commented on PR #13177: URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2448525790
> @peter-toth Hey! I think you've worked on quite a few methods modified by this PR, in case you'd like to take a look 😀 Hi @blaginin, thanks for pinging me. I like the iterative approach, but I'm a bit concerned that this API can be much slower than the recursive one. Do you think you could run some benchmarks? If this implementation turns out to be slow then maybe we could keep the recursive way and use a library like `stacker` or `recursive`. cc @alamb, @ozankabak, @berkaysynnada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
