peter-toth commented on PR #13177: URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2450058718
Hmm, do we have rules that expect BFS traversal? I think the current APIs only support pre-order/post-order (DFS like) traversals. My perf. concern is more about the extra heap allocations that iterative implementations like this need. Also, I don't see yet how this will work on tree nodes that own their children (e.g. `Expr`), where cloning a node's children is costly, taking the children is not straightforward, but the current `map_children()` approach works quite well. If the iterative implementation is not feasible on those trees then we should probably prefer a solution that works well on all kinds of trees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
