findepi commented on code in PR #12978:
URL: https://github.com/apache/datafusion/pull/12978#discussion_r1823895006
##########
datafusion/core/src/physical_optimizer/pruning.rs:
##########
@@ -1567,6 +1581,11 @@ fn build_statistics_expr(
)),
))
}
+ Operator::LikeMatch => build_like_match(expr_builder).ok_or_else(|| {
+ plan_datafusion_err!(
+ "LIKE expression with wildcard at the beginning is not
supported"
+ )
Review Comment:
The idea to return option from `build_like_match` was to avoid communication
"i can't derive predicate" via errors.
Changing `build_statistics_expr` to return Option is too much for this PR,
but we can maybe return an always-true expression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
