peter-toth commented on code in PR #13005:
URL: https://github.com/apache/datafusion/pull/13005#discussion_r1824044558
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -80,7 +79,7 @@ enum EvalMethod {
/// [WHEN ...]
/// [ELSE result]
/// END
-#[derive(Debug, Hash)]
+#[derive(Debug, Hash, PartialEq, Eq)]
Review Comment:
Yeah, this is probably the strangest part of the bug. If you have double
wrappers around `dyn Trait` then there is no issue:
https://github.com/rust-lang/rust/issues/78808#issuecomment-1664012270
`CaseExpr` doesn't have any `dyn Trait` fields with a single wrapper so the
`derive` macro has no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
