alamb commented on code in PR #13005:
URL: https://github.com/apache/datafusion/pull/13005#discussion_r1815683713
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -48,11 +47,11 @@ use kernels::{
};
/// Binary expression
-#[derive(Debug, Hash, Clone)]
-pub struct BinaryExpr {
- left: Arc<dyn PhysicalExpr>,
+#[derive(Debug, Hash, Clone, Eq, PartialEq)]
+pub struct BinaryExpr<DynPhysicalExpr: ?Sized = dyn PhysicalExpr> {
Review Comment:
Github copilot and I banged out the code. However, I think I accidentally
push the commits to your branch 😬 -- hopefully that is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
