findepi commented on code in PR #13147:
URL: https://github.com/apache/datafusion/pull/13147#discussion_r1824611276
##########
datafusion/physical-plan/src/joins/utils.rs:
##########
@@ -246,6 +268,11 @@ pub trait JoinHashMapType {
let next_chain = self.get_list();
for (row_idx, hash_value) in iter {
// Get the hash and find it in the index
+ if let Some(bloom_filter) = self.get_bloom_filter() {
+ if !bloom_filter.contains(hash_value) {
Review Comment:
it could be adaptive. eg when the filter is observed not to filter out
stuff, it could disable itself (for ever, or "for couple batches")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
