alamb commented on PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#issuecomment-2450656951
> It got pretty out of hand because of nth_value and BuiltinWindowFunction
references across the repo so I wanted to open a draft PR to get feedback.
I personally think it would be fine to leave `BuiltInWindowFunction`
initially while we port over the function, and them remove it as a follow on PR
Perhaps you can leave a stub in like
```rust
enum BuiltInWindowFunction {
// Never created, will be removed in a follow on PR
Stub
};
```
Then we can focus this PR on making sure that `nth_value` is working as a
user defined function and then move on in the next PR to mechanically ripping
out the old BuiltInWindowFunction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
