jonahgao commented on code in PR #13242:
URL: https://github.com/apache/datafusion/pull/13242#discussion_r1827248287
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -176,27 +175,6 @@ async fn prepared_statement_type_coercion() -> Result<()> {
Ok(())
}
-#[tokio::test]
-async fn prepared_statement_invalid_types() -> Result<()> {
Review Comment:
Remove this test because now parameters will be cast to the target type.
This is also the behavior of PostgreSQL.
```sh
psql=> prepare p(int) as select 100+$1;
PREPARE
psql=> execute p('100');
?column?
----------
200
(1 row)
psql=> execute p(20.12);
?column?
----------
120
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
