jonahgao commented on code in PR #13242:
URL: https://github.com/apache/datafusion/pull/13242#discussion_r1827252251
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -106,9 +105,9 @@ async fn test_prepare_statement() -> Result<()> {
let ctx = create_ctx_with_partition(&tmp_dir, partition_count).await?;
// sql to statement then to prepare logical plan with parameters
- // c1 defined as UINT32, c2 defined as UInt64 but the params are Int32 and
Float64
- let dataframe =
- ctx.sql("PREPARE my_plan(INT, DOUBLE) AS SELECT c1, c2 FROM test WHERE
c1 > $2 AND c1 < $1").await?;
Review Comment:
PREPARE now returns an empty DataFrame and can't call `with_param_values` on
it. I think this change is reasonable because the result of `PREPARE` is not a
real relation, as it doesn't contain valid rows. Its result is more like DDL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
