alamb commented on code in PR #13228:
URL: https://github.com/apache/datafusion/pull/13228#discussion_r1828267500
##########
datafusion/core/src/datasource/file_format/csv.rs:
##########
@@ -454,7 +455,9 @@ impl CsvFormat {
.has_header
.unwrap_or(state.config_options().catalog.has_header),
)
- .with_delimiter(self.options.delimiter);
+ .with_delimiter(self.options.delimiter)
+ // Support literal NULL or empty string as null
+ .with_null_regex(Regex::new(r"^NULL$|^$").unwrap());
Review Comment:
A configuration option makes sense to me
I poked around for a csv querying benchmark and I can't find one. Perhaps we
should write one 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
