dhegberg commented on code in PR #13228:
URL: https://github.com/apache/datafusion/pull/13228#discussion_r1828539119
##########
datafusion/core/src/datasource/file_format/csv.rs:
##########
@@ -454,7 +455,9 @@ impl CsvFormat {
.has_header
.unwrap_or(state.config_options().catalog.has_header),
)
- .with_delimiter(self.options.delimiter);
+ .with_delimiter(self.options.delimiter)
+ // Support literal NULL or empty string as null
+ .with_null_regex(Regex::new(r"^NULL$|^$").unwrap());
Review Comment:
So, to confirm:
I'll open up a separate PR to implement a benchmark.
When that gets merged I'll update this PR to use a configuration option and
add the new config to the benchmark test to confirm if there is a regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
