viirya commented on code in PR #1055:
URL: https://github.com/apache/datafusion-comet/pull/1055#discussion_r1828817717
##########
common/src/main/scala/org/apache/comet/vector/NativeUtil.scala:
##########
@@ -107,16 +109,16 @@ class NativeUtil {
null
}
- // The array and schema structures are allocated by native side.
- // Don't need to deallocate them here.
- val arrowSchema = ArrowSchema.wrap(schemaAddrs(index))
- val arrowArray = ArrowArray.wrap(arrayAddrs(index))
Review Comment:
This is to follow Arrow spec and is the correct way to use ArrowSchema and
ArrowArray. What you changed is back to previous incorrect approach which
causes some memory issue before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
