kazuyukitanimura commented on PR #1055: URL: https://github.com/apache/datafusion-comet/pull/1055#issuecomment-2476133686
Thank you @andygrove @viirya I addressed memory issues and added DSv2 support (except Iceberg). This is ready for review again. I also run with 1TB by myself. I still see 10% ish speed up that is the order of seconds not `ms`. I think there are some environmental differences between @andygrove 's and mine. Before (1TB) ``` TPCDS Micro Benchmarks: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ q39a: Comet (Scan, Exec) 27979 33349 580 28.0 35.7 1.0X TPCDS Micro Benchmarks: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ q44: Comet (Scan, Exec) 24877 25216 271 115.8 8.6 1.0X ``` After (1TB) ``` TPCDS Micro Benchmarks: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ q39a: Comet (Scan, Exec) 27281 28714 111 28.7 34.8 1.0X TPCDS Micro Benchmarks: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ q44: Comet (Scan, Exec) 23534 23880 388 122.4 8.2 1.0X ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
