jcsherin commented on code in PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#discussion_r1829272956
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -507,17 +507,6 @@ message ScalarUDFExprNode {
enum BuiltInWindowFunction {
UNSPECIFIED = 0; //
https://protobuf.dev/programming-guides/dos-donts/#unspecified-enum
- // ROW_NUMBER = 0;
- // RANK = 1;
- // DENSE_RANK = 2;
- // PERCENT_RANK = 3;
- // CUME_DIST = 4;
- // NTILE = 5;
- // LAG = 6;
- // LEAD = 7;
- FIRST_VALUE = 8;
- LAST_VALUE = 9;
- NTH_VALUE = 10;
Review Comment:
Instead of removing everything just comment out the enums. After the change
you will need to run `regen.sh` again.
This too we can tackle in a cleanup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
