jcsherin commented on code in PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#discussion_r1829221878
##########
datafusion/expr/src/expr.rs:
##########
@@ -693,9 +689,6 @@ impl AggregateFunction {
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
/// Defines which implementation of an aggregate function DataFusion should
call.
pub enum WindowFunctionDefinition {
- /// A built in aggregate function that leverages an aggregate function
- /// A a built-in window function
- BuiltInWindowFunction(BuiltInWindowFunction),
Review Comment:
Let us keep this PR limited to converting `nth_value`. We can handle cleanup
of `BuiltInWindowFunction` in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
