findepi commented on code in PR #13240:
URL: https://github.com/apache/datafusion/pull/13240#discussion_r1829541620
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -123,8 +124,19 @@ pub enum TypeSignature {
/// Specifies Signatures for array functions
ArraySignature(ArrayFunctionSignature),
/// Fixed number of arguments of numeric types.
- /// See
<https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_numeric>
to know which type is considered numeric
+ /// See [`NativeType::is_numeric`] to know which type is considered numeric
+ ///
+ /// [`NativeType::is_numeric`]: datafusion_common
Numeric(usize),
+ /// Fixed number of arguments of numeric types.
+ /// See [`NativeType::is_numeric`] to know which type is considered numeric
+ /// This signature accepts numeric string
+ /// Example of functions In Postgres that support numeric string
+ /// 1. Mathematical Functions, like `abs`
Review Comment:
If we want to follow PostgreSQL behavior, we would need to model `'...'`
literals as unknown type literals. This would be parser / frontend work. It
should have no impact on projects that do not use the DF parser (#12723).
Not sure it's worthwhile to do. For now, let's just focus on coercions and
make them reasonably correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
