goldmedal commented on code in PR #13240:
URL: https://github.com/apache/datafusion/pull/13240#discussion_r1831110002
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -1940,7 +1940,7 @@ select position('' in '')
----
1
-query error DataFusion error: Error during planning: Error during planning:
Int64 and Int64 are not coercible to a common string
+query error DataFusion error: Error during planning: Error during planning:
The signature expected NativeType::String but received Int64
Review Comment:
I think the error message could be confusing 🤔 . I'm not sure. If providing
both of them are `NativeType`, maybe better?
```suggestion
query error DataFusion error: Error during planning: Error during planning:
The signature expected NativeType::String but received NativeType::Int64
```
or
```suggestion
query error DataFusion error: Error during planning: Error during planning:
The signature expected NativeType::String but received ArrowType Int64
```
?
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -109,7 +110,7 @@ pub enum TypeSignature {
/// For example, `Coercible(vec![DataType::Float64])` accepts
/// arguments like `vec![DataType::Int32]` or `vec![DataType::Float32]`
/// since i32 and f32 can be casted to f64
Review Comment:
I think we need to update the doc for the logic type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
