kezhuw opened a new issue, #13300:
URL: https://github.com/apache/datafusion/issues/13300

   ### Is your feature request related to a problem or challenge?
   
   `ResolvedTableReference` is the resolved counterpart of `TableReference`, it 
should derive more but not less assistant traits. For exmaple, we currently 
can't use it as map key, but `TableReference` do fit. This is strange.
   
   One can take `SessionContextProvider` as an example, there is no reason to 
use `HashMap<String, Arc<dyn TableSource>>` but not 
`HashMap<ResolvedTableReference, Arc<dyn TableSource>>` as we have to resolve 
`TableReference` before looking up.
   
   
https://github.com/apache/datafusion/blob/f190fc6de6a6171c1cd6aa99233bc647ed8b1377/datafusion/core/src/execution/session_state.rs#L1600-L1619
   
   ### Describe the solution you'd like
   
   ```diff
   - #[derive(Debug, Clone)]
   + #[derive(Debug, Clone, PartialEq, Eq, Hash, PartialOrd, Ord)]
   pub struct ResolvedTableReference {
   ```
   
   ### Describe alternatives you've considered
   
   I currently have to resort to `TableReference` as map key to avoid 
unnecessary `.to_string()`. 
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to