timsaucer commented on PR #13332: URL: https://github.com/apache/datafusion/pull/13332#issuecomment-2466735250
Wonderful. Thank you. I'll try to review tomorrow. I did dive into the ConcatFunc and I found (and resolved) two issues: 1) when doing concat on pure literals we aren't allowing for utf8view or large utf8view with values. This isn't caught in the unit tests because they don't have these variants 2) `simplify_concat` is changing the merged types to utf8, which is what caused the schema error. I'll put up the PR today or tomorrow to fix both of these, with unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
