alamb commented on code in PR #13332:
URL: https://github.com/apache/datafusion/pull/13332#discussion_r1844306243
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -224,6 +224,7 @@ fn encode_process(value: &ColumnarValue, encoding:
Encoding) -> Result<ColumnarV
ColumnarValue::Array(a) => match a.data_type() {
DataType::Utf8 => encoding.encode_utf8_array::<i32>(a.as_ref()),
DataType::LargeUtf8 =>
encoding.encode_utf8_array::<i64>(a.as_ref()),
+ DataType::Utf8View =>
encoding.encode_utf8_array::<i32>(a.as_ref()),
Review Comment:
I think this means the output type will be Utf8 but for this type i think
that is totally fine (there is no need to preserve the view encoding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
