buraksenn commented on code in PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#discussion_r1835785304
##########
datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs:
##########
@@ -1500,129 +1494,6 @@ mod tests {
Ok(source)
}
- // Tests NTH_VALUE(negative index) with memoize feature.
- // To be able to trigger memoize feature for NTH_VALUE we need to
- // - feed BoundedWindowAggExec with batch stream data.
- // - Window frame should contain UNBOUNDED PRECEDING.
- // It hard to ensure these conditions are met, from the sql query.
- #[tokio::test]
- async fn test_window_nth_value_bounded_memoize() -> Result<()> {
Review Comment:
same as:
https://github.com/apache/datafusion/pull/13201#discussion_r1835785085
I could not build a valid physical layer window expression that would work.
Can I get help on this too if possible @jcsherin @berkaysynnada ? An example
would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
