buraksenn commented on code in PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#discussion_r1835784248
##########
datafusion/core/tests/fuzz_cases/window_fuzz.rs:
##########
@@ -415,36 +414,6 @@ fn get_random_function(
),
);
}
- window_fn_map.insert(
- "first_value",
- (
- WindowFunctionDefinition::BuiltInWindowFunction(
- BuiltInWindowFunction::FirstValue,
- ),
- vec![arg.clone()],
- ),
- );
- window_fn_map.insert(
- "last_value",
- (
- WindowFunctionDefinition::BuiltInWindowFunction(
- BuiltInWindowFunction::LastValue,
- ),
- vec![arg.clone()],
- ),
- );
- window_fn_map.insert(
- "nth_value",
- (
- WindowFunctionDefinition::BuiltInWindowFunction(
- BuiltInWindowFunction::NthValue,
- ),
- vec![
- arg.clone(),
- lit(ScalarValue::Int64(Some(rng.gen_range(1..10)))),
- ],
- ),
- );
Review Comment:
done thanks
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2172,31 +2171,6 @@ mod tests {
Ok(())
}
- #[tokio::test]
- async fn select_with_window_exprs() -> Result<()> {
- // build plan using Table API
- let t = test_table().await?;
- let first_row = Expr::WindowFunction(WindowFunction::new(
- WindowFunctionDefinition::BuiltInWindowFunction(
- BuiltInWindowFunction::FirstValue,
- ),
Review Comment:
done thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
