joseph-isaacs commented on code in PR #13290:
URL: https://github.com/apache/datafusion/pull/13290#discussion_r1836542191
##########
datafusion/expr/src/udf.rs:
##########
@@ -227,6 +224,19 @@ impl ScalarUDF {
self.inner.invoke_batch(args, number_rows)
}
+ /// Invoke the function on `args`, returning the appropriate result.
+ ///
+ /// See [`ScalarUDFImpl::invoke_batch`] for more details.
+ pub fn invoke_batch_with_return_type(
+ &self,
+ args: &[ColumnarValue],
+ number_rows: usize,
+ return_type: &DataType,
Review Comment:
Do you think we should roll all the values into this struct or just
number_rows and return_type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
