joseph-isaacs commented on code in PR #13290:
URL: https://github.com/apache/datafusion/pull/13290#discussion_r1838263857
##########
datafusion/expr/src/udf.rs:
##########
@@ -227,6 +224,19 @@ impl ScalarUDF {
self.inner.invoke_batch(args, number_rows)
}
+ /// Invoke the function on `args`, returning the appropriate result.
+ ///
+ /// See [`ScalarUDFImpl::invoke_batch`] for more details.
+ pub fn invoke_batch_with_return_type(
+ &self,
+ args: &[ColumnarValue],
+ number_rows: usize,
+ return_type: &DataType,
Review Comment:
I think a better name than
```rust
pub fn invoke_batch_with_return_type(
&self,
args: InvokeArgs
) -> Result<ColumnarValue> {
```
is needed, maybe invoke_with_args(), I don't like it that much, but not sure
on the name.
```rust
pub fn invoke_with_args(
&self,
args: InvokeArgs
) -> Result<ColumnarValue> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
