jcsherin commented on code in PR #13201:
URL: https://github.com/apache/datafusion/pull/13201#discussion_r1836709044
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -911,6 +912,9 @@ async fn roundtrip_expr_api() -> Result<()> {
count_distinct(lit(1)),
first_value(lit(1), None),
first_value(lit(1), Some(vec![lit(2).sort(true, true)])),
+ functions_window::nth_value::first_value(lit(1)),
+ functions_window::nth_value::last_value(lit(1)),
Review Comment:
These expression functions (`first_value` and `last_value`) did not exist
before. There is only `nth_value` here:
https://docs.rs/datafusion/latest/datafusion/logical_expr/window_function/index.html#functions
I guess it is alright.
Thanks for adding them 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
